fix(patch): drop the dead first-run provider chooser from onboarding - #317
Open
HuangLeijiana wants to merge 1 commit into
Open
fix(patch): drop the dead first-run provider chooser from onboarding#317HuangLeijiana wants to merge 1 commit into
HuangLeijiana wants to merge 1 commit into
Conversation
The settings-models patch rewrote the first-run dialog to advertise
choosing among twelve providers ('Choose a provider and enter its API
key'), added an ONBOARDING_PROVIDERS catalog and a selectedProvider
state, but never rendered the chooser: setSelectedProvider has zero
call sites and the onboardingProvider/onboardingManufacturer/… keys are
never read. New users were locked to the default row (DeepSeek or
whichever provider sorted first) while the copy promised a picker.
Revert the onboarding dialog to the upstream single-provider flow and
copy (configures the default DeepSeek provider it actually shows) and
remove the dead catalog/state/keys, keeping the real provider grid in
the settings add-provider flow untouched. The patch was regenerated
from pristine and verified: it applies cleanly and reproduces the
edited artifact byte-for-byte. The patch test now asserts the dead code
is gone instead of pinning its presence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings-models patch rewrote the first-run dialog to advertise choosing among twelve providers ('Choose a provider and enter its API key'), added an ONBOARDING_PROVIDERS catalog and a selectedProvider state, but never rendered the chooser: setSelectedProvider has zero call sites and the onboardingProvider/onboardingManufacturer/… keys are never read. New users were locked to the default row (DeepSeek or whichever provider sorted first) while the copy promised a picker.
Revert the onboarding dialog to the upstream single-provider flow and copy (configures the default DeepSeek provider it actually shows) and remove the dead catalog/state/keys, keeping the real provider grid in the settings add-provider flow untouched. The patch was regenerated from pristine and verified: it applies cleanly and reproduces the edited artifact byte-for-byte. The patch test now asserts the dead code is gone instead of pinning its presence.