ci: guard against patch drift on the vendored harness tarballs - #318
Open
HuangLeijiana wants to merge 1 commit into
Open
ci: guard against patch drift on the vendored harness tarballs#318HuangLeijiana wants to merge 1 commit into
HuangLeijiana wants to merge 1 commit into
Conversation
patch-package only replays the tracked patches during npm ci's postinstall and only on machines that run a fresh install; on a TTY a failed hunk also exits 0 unless --error-on-fail is passed, and the repo tests assert marker strings inside the patch text rather than whether a hunk still fits its context. A harness bump that shifts patch context could therefore ship silently. Add scripts/verify-patches.mjs, which unpacks each vendored tarball from packages/harness-0.1.2-rc.1 into an isolated node_modules and replays exactly that patch with --error-on-fail (verified: 20/20 apply today), and a GitHub Actions job that runs it on any PR touching patches/, the vendored tarballs, or the lockfile — without downloading Electron. Also expose it as npm run verify:patches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch-package only replays the tracked patches during npm ci's postinstall and only on machines that run a fresh install; on a TTY a failed hunk also exits 0 unless --error-on-fail is passed, and the repo tests assert marker strings inside the patch text rather than whether a hunk still fits its context. A harness bump that shifts patch context could therefore ship silently.
Add scripts/verify-patches.mjs, which unpacks each vendored tarball from packages/harness-0.1.2-rc.1 into an isolated node_modules and replays exactly that patch with --error-on-fail (verified: 20/20 apply today), and a GitHub Actions job that runs it on any PR touching patches/, the vendored tarballs, or the lockfile — without downloading Electron. Also expose it as npm run verify:patches.