Conversation
Up to standards ✅🟢 Issues
|
| Category | Results |
|---|---|
| Complexity | 2 medium |
🟢 Metrics 28 complexity · 10 duplication
Metric Results Complexity 28 Duplication 10
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
added 2 commits
May 4, 2026 03:29
Signed-off-by: Tanvir Alam <tanvralm@amazon.com>
Signed-off-by: Tanvir Alam <tanvralm@amazon.com>
Collaborator
Author
|
Thanks @XiangpengHao! Really appreciate you taking this on — you know the codebase best and glad the discussion and exploration here was useful in shaping the direction. Will check out #495 and leave any thoughts there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds configurable disk size limits to LiquidCache with automatic eviction when the budget is exceeded, and a Parquet fallback reader so queries don't crash if a cache entry is evicted mid-read.
Changes
1. Parquet Fallback Reader
When
ReadFromCacheencounters a missing entry (evicted from cache), it reads the batch directly from the source Parquet file instead of erroring. This makes the read path resilient to concurrent eviction.2. Disk Eviction
Configurable
max_disk_byteswith a watermark (default 0.9). When disk usage exceedsmax_disk_bytes * watermark, entries are evicted via the cache policy'sfind_disk_victims(FIFO among disk entries forLiquidPolicy).3. Configuration
How it works
Testing
BudgetAccountingdisk tracking,ArtIndex::remove,LiquidPolicy::find_disk_victims, fallback reader with evicted batch