Skip to content

Switch to cache vortex array - #517

Merged
XiangpengHao merged 2 commits into
mainfrom
vortex-adapter
Sep 4, 2026
Merged

XiangpengHao merged 2 commits into
mainfrom
vortex-adapter

Conversation

@XiangpengHao

Copy link
Copy Markdown
Collaborator

I think vortex is well maintained and this switch actually gets slightly performance gain.

We'll add back some liquid cache secret sauce very soon

@XiangpengHao XiangpengHao changed the title Switch to use vortex array Switch to cache vortex array Sep 4, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 5 medium

Results:
5 new issues

Category Results
Complexity 5 medium

View in Codacy

🟢 Metrics 69 complexity · 1 duplication

Metric Results
Complexity 69
Duplication 1

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.33071% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.49%. Comparing base (3c89a8d) to head (d1e15dc).

Files with missing lines Patch % Lines
src/core/src/liquid_array/array.rs 94.00% 21 Missing and 15 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   83.83%   82.49%   -1.35%     
==========================================
  Files          82       66      -16     
  Lines       16254    11872    -4382     
  Branches    16254    11872    -4382     
==========================================
- Hits        13627     9794    -3833     
+ Misses       2368     1829     -539     
+ Partials      259      249      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Comparison

Current: a202b80a (Liquid) vs Baseline: a202b80a (DataFusionDefault)

Query Cold Time Δ Warm Time Δ CPU Time Δ
Q1 4.0ms (3.0ms) +33.3% 0.000ms (0.000ms) +0.0% 0.000ms (0.000ms) +0.0%
Q2 21.0ms (6.0ms) +250.0% 5.5ms (6.0ms) -8.3% 7.0ms (6.5ms) +7.7%
Q3 17.0ms (14.0ms) +21.4% 7.5ms (11.5ms) -34.8% 3.0ms (22.0ms) -86.4%
Q4 18.0ms (12.0ms) +50.0% 4.5ms (11.0ms) -59.1% 2.5ms (24.0ms) -89.6%
Q5 64.0ms (52.0ms) +23.1% 59.5ms (51.5ms) +15.5% 4.5ms (26.5ms) -83.0%
Q6 245.0ms (101.0ms) +142.6% 85.0ms (108.0ms) -21.3% 30.0ms (80.5ms) -62.7%
Q7 1.0ms (1.0ms) +0.0% 1.0ms (0.000ms) +inf% 0.000ms (0.000ms) +0.0%
Q8 9.0ms (6.0ms) +50.0% 6.0ms (5.0ms) +20.0% 7.5ms (6.5ms) +15.4%
Q9 105.0ms (91.0ms) +15.4% 94.5ms (88.0ms) +7.4% 8.0ms (45.0ms) -82.2%
Q10 107.0ms (88.0ms) +21.6% 86.5ms (87.5ms) -1.1% 6.5ms (62.0ms) -89.5%
Q11 50.0ms (26.0ms) +92.3% 26.0ms (26.5ms) -1.9% 46.5ms (37.5ms) +24.0%
Q12 53.0ms (29.0ms) +82.8% 25.0ms (30.0ms) -16.7% 46.5ms (44.5ms) +4.5%
Q13 289.0ms (110.0ms) +162.7% 104.5ms (113.5ms) -7.9% 74.0ms (79.5ms) -6.9%
Q14 563.0ms (139.0ms) +305.0% 139.5ms (140.5ms) -0.7% 82.0ms (106.5ms) -23.0%
Q15 327.0ms (107.0ms) +205.6% 137.5ms (111.5ms) +23.3% 80.0ms (96.0ms) -16.7%
Q16 155.0ms (119.0ms) +30.3% 132.0ms (112.0ms) +17.9% 4.5ms (25.5ms) -82.4%
Q17 618.0ms (227.0ms) +172.2% 242.0ms (231.0ms) +4.8% 67.0ms (105.5ms) -36.5%
Q18 647.0ms (224.0ms) +188.8% 237.5ms (225.0ms) +5.6% 67.0ms (106.0ms) -36.8%
Q19 966.0ms (425.0ms) +127.3% 397.0ms (456.0ms) -12.9% 95.5ms (149.5ms) -36.1%
Q20 16.0ms (12.0ms) +33.3% 3.0ms (11.5ms) -73.9% 8.0ms (24.5ms) -67.3%
Q21 589.0ms (174.0ms) +238.5% 475.0ms (173.5ms) +173.8% 297.5ms (267.5ms) +11.2%
Q22 897.0ms (159.0ms) +464.2% 595.5ms (165.0ms) +260.9% 180.0ms (337.5ms) -46.7%
Q23 1.92s (461.0ms) +315.4% 1.59s (465.0ms) +241.5% 547.5ms (737.0ms) -25.7%
Q24 26.34s (941.0ms) +2699.0% 974.0ms (954.5ms) +2.0% 652.0ms (2.60s) -75.0%
Q25 359.0ms (73.0ms) +391.8% 17.5ms (59.5ms) -70.6% 45.5ms (123.5ms) -63.2%
Q26 143.0ms (44.0ms) +225.0% 20.0ms (44.5ms) -55.1% 54.0ms (82.5ms) -34.5%
Q27 295.0ms (58.0ms) +408.6% 26.0ms (60.0ms) -56.7% 74.0ms (121.0ms) -38.8%
Q28 773.0ms (213.0ms) +262.9% 709.0ms (215.5ms) +229.0% 204.5ms (275.5ms) -25.8%
Q29 1.41s (991.0ms) +42.1% 1.16s (1.01s) +14.3% 432.5ms (354.0ms) +22.2%
Q30 29.0ms (26.0ms) +11.5% 22.0ms (32.5ms) -32.3% 6.5ms (22.0ms) -70.5%
Q31 658.0ms (114.0ms) +477.2% 88.5ms (104.5ms) -15.3% 77.5ms (142.5ms) -45.6%
Q32 1.10s (103.0ms) +968.0% 140.0ms (106.0ms) +32.1% 115.5ms (149.0ms) -22.5%
Q33 397.0ms (365.0ms) +8.8% 357.5ms (356.5ms) +0.3% 8.5ms (72.0ms) -88.2%
Q34 893.0ms (442.0ms) +102.0% 463.0ms (436.0ms) +6.2% 144.0ms (271.0ms) -46.9%
Q35 872.0ms (440.0ms) +98.2% 461.0ms (444.0ms) +3.8% 148.5ms (269.0ms) -44.8%
Q36 116.0ms (115.0ms) +0.9% 96.0ms (115.5ms) -16.9% 4.5ms (27.0ms) -83.3%
Q37 309.0ms (106.0ms) +191.5% 79.5ms (100.0ms) -20.5% 27.5ms (69.5ms) -60.4%
Q38 75.0ms (43.0ms) +74.4% 28.0ms (43.5ms) -35.6% 17.5ms (23.0ms) -23.9%
Q39 324.0ms (47.0ms) +589.4% 32.5ms (48.5ms) -33.0% 20.0ms (71.0ms) -71.8%
Q40 737.0ms (200.0ms) +268.5% 228.5ms (182.5ms) +25.2% 64.5ms (124.0ms) -48.0%
Q41 25.0ms (20.0ms) +25.0% 12.0ms (18.5ms) -35.1% 8.0ms (17.0ms) -52.9%
Q42 21.0ms (20.0ms) +5.0% 10.5ms (18.0ms) -41.7% 8.0ms (15.5ms) -48.4%
Q43 40.0ms (15.0ms) +166.7% 11.0ms (15.0ms) -26.7% 7.0ms (11.0ms) -36.4%

⚠️ LiquidCache is slower on 11 queries (warm)

  • Q7: warm +inf% (1.0ms vs 0.000ms)
  • Q22: warm +260.9% (595.5ms vs 165.0ms)
  • Q23: warm +241.5% (1.59s vs 465.0ms)
  • Q28: warm +229.0% (709.0ms vs 215.5ms)
  • Q21: warm +173.8% (475.0ms vs 173.5ms)
  • Q32: warm +32.1% (140.0ms vs 106.0ms)
  • Q40: warm +25.2% (228.5ms vs 182.5ms)
  • Q15: warm +23.3% (137.5ms vs 111.5ms)
  • Q8: warm +20.0% (6.0ms vs 5.0ms)
  • Q16: warm +17.9% (132.0ms vs 112.0ms)
  • Q5: warm +15.5% (59.5ms vs 51.5ms)

Compared Liquid vs DataFusionDefault on the same runner
Regressions: warm-time increases of at least 15%. Cold Time: first iteration; Warm Time: median of remaining iterations.

@XiangpengHao
XiangpengHao merged commit bd2a4e3 into main Sep 4, 2026
15 checks passed
@XiangpengHao
XiangpengHao deleted the vortex-adapter branch September 4, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant