Draft
Conversation
Pull Request Test Coverage Report for Build 561
💛 - Coveralls |
akariv
requested changes
Sep 24, 2021
Member
akariv
left a comment
There was a problem hiding this comment.
Left a few comments - also don't forget to update PROCESSORS.md
|
|
||
| def func(package): | ||
| matcher = ResourceMatcher(resources, package.pkg) | ||
| yield package.pkg |
Member
There was a problem hiding this comment.
Before yielding here, you can process the datapackage itself and remove the from_key field if source_delete and from_key != to_key.
dataflows/processors/unwind.py
Outdated
Member
There was a problem hiding this comment.
I think we should also add here the 'to_key' field (with its type and other options)
(or - if from_key == to_key - update the field's type accordingly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: