refactor(auth): return EnvCredentials by value in VerifyEnvCredentials#374
Open
ahjota wants to merge 1 commit intodatarobot-oss:mainfrom
Open
refactor(auth): return EnvCredentials by value in VerifyEnvCredentials#374ahjota wants to merge 1 commit intodatarobot-oss:mainfrom
ahjota wants to merge 1 commit intodatarobot-oss:mainfrom
Conversation
- Change VerifyEnvCredentials() signature from (*EnvCredentials, error) to (EnvCredentials, error) - Update test assertions to check struct fields directly instead of pointer non-nil - Document GetEnvCredentials and VerifyEnvCredentials in authentication.md This makes the return type consistent with GetEnvCredentials, which already returns by value. Since EnvCredentials is a small struct (two strings), returning by value is more idiomatic. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RATIONALE
Was reviewing the code in #354 again and saw a couple of things to fix.
CHANGES
This makes the return type consistent with GetEnvCredentials, which already returns by value. EnvCredentials is a small struct (two strings) anyway.
PR Automation
Comment-Commands: Trigger CI by commenting on the PR:
/trigger-smoke-testor/trigger-test-smoke- Run smoke tests/trigger-install-testor/trigger-test-install- Run installation testsLabels: Apply labels to trigger workflows:
run-smoke-testsorgo- Run smoke tests on demand (only works for non-forked PRs)Important
For Forked PRs: If you're an external contributor, the
run-smoke-testslabel won't work. Only maintainers can trigger smoke tests on forked PRs by applying theapproved-for-smoke-testslabel after security review. Please comment requesting maintainer review if you need smoke tests to run.