Full adaptation of CI/CD to parametrized FIND_PAGE_SIZE#425
Open
sl-at-ibm wants to merge 3 commits into
Open
Conversation
Coverage reportfor commit: |
erichare
reviewed
Jun 19, 2026
| NUM_DOCS = 2 * PAGE_SIZE + 5 | ||
| NUM_DOCS_PAGINATION = 2 * (2 * PAGE_SIZE) + 5 | ||
| # TODO: once v1.0.48 is in production, hardcode 50 and bump Data API version in docker compose file: | ||
| FIND_PAGE_SIZE = int(os.environ.get("FIND_PAGE_SIZE") or "20") |
Collaborator
There was a problem hiding this comment.
Do we want the fallback value to be 20 here, or should it be 50 to match the new server default?
Oh, LOL i typed that before i read your comment above. Makes sense we should wait till its in production!
erichare
reviewed
Jun 19, 2026
| Prepend tests with a `ASTRAPY_TEST_LATEST_MAIN=y` for features found on `main` that are not released anywhere. | ||
| _(Tip: run a code search first to see what is currently marked as such. Chances are nothing is.)_ | ||
|
|
||
| ### Page size increase (starting in v1.0.48) |
Collaborator
There was a problem hiding this comment.
Perfect. I need to read the whole PR before commenting in the future 😄
erichare
reviewed
Jun 19, 2026
Collaborator
There was a problem hiding this comment.
Do we need to make the corresponding changes in test_table_cursor_sync as well?
erichare
reviewed
Jun 19, 2026
| required: true | ||
| HEADER_EMBEDDING_API_KEY_VOYAGEAI: | ||
| required: true | ||
| FIND_PAGE_SIZE: |
Collaborator
There was a problem hiding this comment.
Do we also need to include FIND_PAGE_SIZE in the release workflow? i think it runs the integration tests directly
erichare
requested changes
Jun 19, 2026
erichare
left a comment
erichare
left a comment
Collaborator
There was a problem hiding this comment.
Left a couple comments @sl-at-ibm, possible places that might also need adapting (not 100% sure) hence the request changes. Let me know if im off base though and ill approve!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation to deploy of Data API v1.0.48, with (deploy-time) configurable page size, this PR completes the adaptation of integration tests to cope with this change.
The changes here are inert unless the tests are run after e.g.
export FIND_PAGE_SIZE=50. So this can be merged any time now. Once Astra prod gets the new page size (of 50 by default), setting a new repo env variable will make the tests run smoothly.At that point, it might be even simpler to bump the HCD compose data api version to 1.0.48 and hardcode 50 again.
Note that right now the workflow yamls transmit the repo secret (for
FIND_PAGE_SIZEall the way to the Astra integration test only, because this repo has full control over the HCD case (and will manage the version used there)).