test: migrate httproute-accepted e2e from infra#237
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
ecv
force-pushed
the
test/migrate-httproute-accepted-from-infra
branch
from
July 13, 2026 20:38
fba3421 to
7d5dfd5
Compare
Confirm a user's HTTPRoute is admitted end to end: an HTTPRoute attached to a Datum gateway reaches the Accepted state, so downstream traffic programming can proceed. Per datum-cloud/infra#3006, single-service API-contract tests move out of the infra live-env Chainsaw suite into their owning repo's local kind harness, run pre-merge. The gateway.networking.k8s.io HTTPRoute contract is owned by NSO, so it belongs here. The test mirrors the gateway sibling's proven setup on the prod-fidelity harness: a self-signed CA on the downstream cluster, an upstream GatewayClass, a verified Domain, and a Gateway that reaches Accepted. It then provisions an HTTPRoute and asserts acceptance on the per-parent status condition (status.parents[].conditions[]), where the Gateway API surfaces route acceptance, rather than a top-level condition.
ecv
force-pushed
the
test/migrate-httproute-accepted-from-infra
branch
from
July 15, 2026 16:26
1cc6ea9 to
8fe4348
Compare
Chainsaw matches a bare conditions array positionally and by length, so an expected list with only the Accepted condition never matches the route's two-entry status (Accepted + ResolvedRefs) and the assert times out. Assert both conditions, mirroring the gateway sibling.
Contributor
Author
|
Verified end-to-end now — the draft caveats above are resolved. The branch was well behind
E2E Tests is green: |
ecv
marked this pull request as ready for review
July 15, 2026 21:38
ecv
enabled auto-merge
July 16, 2026 01:20
scotwells
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an
httproute-acceptedend-to-end test to NSO's local kind harness attest/e2e/httproute-accepted/. It provisions aGatewayand anHTTPRouteand asserts the route reachesAccepted, so downstream traffic programming can proceed.Why
Per
datum-cloud/infra#3006, single-service API-contract tests are moving out of the infra live-env Chainsaw suite into their owning repo's local kind harness, run pre-merge. Thegateway.networking.k8s.ioHTTPRoute contract is owned by NSO, so it belongs here. Related:datum-cloud/infra#3005.Approach
The test mirrors the
gatewaysibling's proven setup on the prod-fidelity harness:nso-infra),GatewayClass,Domain(e2e.env.datum.net),Gatewaywith HTTP + HTTPS listeners that reachesAccepted,HTTPRoute+ backendEndpointSlice, then an assert that the route isAccepted.Two details worth calling out, both learned from CI:
Note
Route acceptance is asserted on the per-parent condition (
status.parents[].conditions[]), where the Gateway API surfaces it — the HTTPRoute never populates a top-levelAcceptedcondition, so akubectl wait --for=condition=Acceptedcan't observe it.Note
The
conditionslist asserts bothAcceptedandResolvedRefs. Chainsaw matches a bare array positionally and by length, so an expected list carrying onlyAcceptednever matches the route's two-entry status.Test plan
chainsaw lintpasses.httproute-acceptedpasses in ~7s alongside the rest of the suite. This is verified against a running harness, not just linted.