Skip to content

fix: allow RESPONSE_CODE_DETAILS and START_TIME in error page #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdjenkinson merged 2 commits into from
Jul 15, 2026
Merged

fix: allow RESPONSE_CODE_DETAILS and START_TIME in error page #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a6a66f
fix: allow RESPONSE_CODE_DETAILS and START_TIME in error page
mattdjenkinson Jul 14, 2026
0801835
Merge branch 'main' into fix/error-page-allowlist-response-details-st…
mattdjenkinson Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/extensionserver/mutate/localreply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ func buildLocalReplyConfig(cfg *LocalReplyConfig) *hcmv3.LocalReplyConfig {
// re-trigger the exact listener rejection this escaper exists to prevent
// (issue #243). Keep entries longest-first so matching is unambiguous.
var envoyBodyAllowedCommands = []string{
"%START_TIME(%Y-%m-%d %H:%M:%S UTC)%",
"%RESPONSE_CODE_DETAILS%",
"%RESPONSE_CODE%",
}

Expand Down
2 changes: 2 additions & 0 deletions internal/extensionserver/mutate/localreply_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,8 @@ func TestEscapeEnvoyFormatLiterals(t *testing.T) {
{"bare percent in css", "height: 100%;", "height: 100%%;"},
{"multiple bare percents", "120% 50% 0%", "120%% 50%% 0%%"},
{"preserve allowlisted command", "code %RESPONSE_CODE% end", "code %RESPONSE_CODE% end"},
{"preserve allowlisted response code details", "details: %RESPONSE_CODE_DETAILS%", "details: %RESPONSE_CODE_DETAILS%"},
{"preserve allowlisted start time", "at %START_TIME(%Y-%m-%d %H:%M:%S UTC)%", "at %START_TIME(%Y-%m-%d %H:%M:%S UTC)%"},
{"escape non-allowlisted command", "%REQ(x-header)%", "%%REQ(x-header)%%"},
{"escape non-allowlisted command with length", "%REQ(x-header):10%", "%%REQ(x-header):10%%"},
{"escape command-shaped literal", "progress %COMPLETE% now", "progress %%COMPLETE%% now"},
Expand Down
Loading