Repository navigation
Conversation
privateip
added a commit
that referenced
this pull request
Oct 12, 2026
PR #34 adds rule_admission_envtest_test.go too, so the two would conflict. Also state on the field that ratcheting needs Kubernetes 1.30 or later, and what an older API server does instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow an NLB rule to specify backend IPv6 addresses without relying on attachment labels.
backendSelectormay be omitted only whenbackendAddressesis present; a rule with neither field remains invalid.This retains the VPC boundary: Galactic must match each address against a
VPCAttachmentwhose authoritativestatus.vpcequals the rule'svpcRef.Stacked on #33.
Verification
task buildtask lintgo test ./api/v1alpha1 -count=1(admission envtest runs whenKUBEBUILDER_ASSETSis configured)