Skip to content

react and react-dom are optional peers but plot() and legend() need them #175

Closed

Description

@dave-hillier

plot() (src/plotDom.ts on main) and legend() (src/legends.js) render through react-dom/server's renderToStaticMarkup, but package.json marks react and react-dom as optional in peerDependenciesMeta. Installing the package without React and calling Plot.plot() or Plot.legend() fails at runtime.

Fix: make react and react-dom required peers by removing them from peerDependenciesMeta.

Activity

  1. dave-hillier commented on Sep 24, 2026

    @dave-hillier
    OwnerAuthor

    Fixed and merged in #182 (merged as 8c86cfe):

    • 304302f3 Require react and react-dom as peers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions