Repository navigation
Finish the last item of #154 and of #166 - #183
Merged
Merged
Conversation
#154 asked for no <style> blocks in TSX. Replot.tsx's remained, because every pass over it was deferred while that file was being restructured. The stylesheet and the element that carries it now live in plotStyles.ts, as the legend stylesheets already do, and both render paths take the same element rather than each writing their own. #166 asked for the @ts-expect-error on tree.ts's import of maybeTreeAnchor to go: the runtime export was simply missing from transforms/tree.d.ts, so it is declared there instead of suppressed. Neither changes what is rendered: 1818 tests pass with no snapshot movement. Co-Authored-By: Claude Code <noreply@anthropic.com>
Declaring it in transforms/tree.d.ts made the API-data generator look for a docs anchor for it and fail the docs build, which is what CI caught. The generator already has a list of internal exports it skips; this belongs on it, next to the other maybe* helpers. Co-Authored-By: Claude Code <noreply@anthropic.com>
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two residual items left by #182, one from #154 and one from #166.
#154 asked for no
<style>blocks in TSX.Replot.tsx's was the last one standing, because every pass over it while it was being restructured deferred the change. The stylesheet and the element that carries it now live inplotStyles.ts, the way the legend stylesheets already live inlegendStyles.ts, and both render paths —<PlotSvg>andbuildStaticPlotSvg— take the same element rather than each writing its own. That was also #180's third item, the duplicated stylesheet.#166 asked for the
@ts-expect-errorontree.ts's import ofmaybeTreeAnchorto go. The runtime export was simply missing fromtransforms/tree.d.ts, so it is declared there and the suppression is gone.Neither changes what is rendered: 1818 tests pass, no snapshot moves, and tsc, lint and prettier are clean.
🤖 Generated with Claude Code