github action to build the binaries on windows#82
Open
MXZZ wants to merge 43 commits into
Open
Conversation
added 30 commits
July 5, 2026 10:28
build actions re-added
Feature/tool restructuring (davi0015#83)
synching with davi0015 branch
Owner
|
use feature branch to create a pull request |
davi0015
reviewed
Jul 15, 2026
| this._rerender = res.rerender; | ||
|
|
||
| this._register(this._reactComponentDisposable); | ||
| this._register(res); |
davi0015
reviewed
Jul 15, 2026
| jobs: | ||
| build-windows: | ||
| name: Build on Windows | ||
| runs-on: windows-latest |
Owner
There was a problem hiding this comment.
The Windows job hardcodes VS 2026 (v18) but runs on windows-latest with no fallback — unlike the macOS job which pins macos-14. Can you confirm this builds green against the current windows-latest image? If VS 18 isn't on it, npm ci will fail hard.
Author
There was a problem hiding this comment.
Hi Davi0015!! thanks, yes it works i'm using it on my computer, i ve made those with opus4.8 so I dont mind to do some fixes , let me know
Owner
There was a problem hiding this comment.
got it, please check the other 2 comments
synch from davi00015 repo
synch with main fork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to build both portable and standard version of vscode