Less case sensitive header name (browser compatibility)#1
Open
brezniczky wants to merge 1 commit intodavidgf:masterfrom
Open
Less case sensitive header name (browser compatibility)#1brezniczky wants to merge 1 commit intodavidgf:masterfrom
brezniczky wants to merge 1 commit intodavidgf:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi David!
Thanks a lot for bringing this useful tutorial together (referring to the Medium article)!
In the comments someone mentions - and this is as well my experience in practice with Firefox - that the Authorization header with the credentials reaches the authorizer in all lower case. I also checked with a recent/latest Chromium, it was the same, this commit obviously addresses that.
(And a second note: I am uncertain whether it is a useful suggestion in such illustrative scenarios, but some LICENSE could be useful for this repo as well. I am planning to put a lot of the code to good use for a temporary in-house solution - I pulled a lot of hair out over trying to integrate Cognito for no serious immediate need :) so I guess it can come useful for others too. Of course feel free to ignore this part if you disagree for any reason.)