Repository navigation
Search: say where a matched moment ends - #36
Merged
Merged
Conversation
A spoken hit carried only its start_time. Gecko Video Creator turns a hit
("where people talk about X") into a trimmed clip, and with only a start
it would have to guess the out point.
The end is looked up from the transcript segments once per search, for
the page that is actually returned. The keyword index stores only the
start, and adding a column there would mean rebuilding the whole FTS
index in a migration.
Both retrievers get it: a moment found only by meaning has its end too.
A metadata hit, or one whose segment has since been deleted, says null
rather than something wrong.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016fiRJAt34ag62iPiuMkNhm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gecko Video Creator needs this change (GAM-1 in gvc's plan of attack). GVC turns a search hit ("where people talk about X") into a trimmed clip, and with only
start_timeit would have to guess the out point.What changes
GET /api/searchhits now carryend_timenext tostart_time. It's the end of the matched transcript segment.TranscriptSegmentin one query per search, and only for the page being returned (services/search.py::_attach_end_times). It isn't stored in the FTS index: the index holds only the start, and adding a column there would mean rebuilding the whole index in a migration.null.SearchHit.end_timeis added to the type. No UI uses it yet.docs/plan-of-attack.md: the documented result shape now includesend_time.Tests
test_search_api.py:(412.0, 417.0);null/null.pytest -qpasses, 1250 tests.npm test(393 tests) and build all pass.🤖 Generated with Claude Code
https://claude.ai/code/session_016fiRJAt34ag62iPiuMkNhm
Generated by Claude Code