Repository navigation
M2b: timed overlays, credits and Save to GAM - #4
Merged
Merged
Conversation
Text, lower thirds and pictures are drawn over the stitched video in one extra pass, each in its window with alpha fades, so one can be held across a join. Their anchors default to their own scene and may name a line or a later scene; one that cannot be placed is dropped with a warning. Credits come from each GAM asset's credit, in order of first use and said once, plus extra lines: as end cards (split past a screenful) and in a description with the chapters, to paste where the video goes. A finished full render can be saved to GAM as a gvc_export with its project and render as origin (GAM-3), named and described, once. The editor gets an On screen section per scene, a Credits section in the Render tab, Save to GAM, and the description with a copy button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016fiRJAt34ag62iPiuMkNhm
davior
marked this pull request as ready for review
October 16, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finishes M2 of the plan of attack. Renders now draw what the VideoSpec already described but M2a only warned about: on-screen text, lower thirds and pictures. They also carry credits, and a finished render can be filed back into GAM.
Pairs with davior/gam#37 (GAM-3). Merge order doesn't matter. Against a GAM without it, Save to GAM still works, and the file lands as an ordinary upload instead of a "Video Creator" export.
What you can do
0:00 Titlelines, then credits) with a Copy button.How
ffmpeg.build_overlay_pass). Each layer is a full-frame PNG drawn by Pillow, looped, alpha-faded at absolute times, and composited withoverlay=…:enable='between(t,a,b)'.compile.place_overlaysfollowsplace_tracks:media.resolvenow keeps each asset's GAM credit.credits.credit_linesorders them by first use, says each once, and appends the extra lines.credits_unitsappends end cards, splitting past 18 lines.POST /api/renders/{id}/save-to-gamstreams the file as the requester, sendingsource=gvc_export,origin_project_idandorigin_reference_id.render_job.descriptionandrender_job.gam_asset_id, run by the entrypoint as usual.AnchorSelect,spec/anchors.ts) between the Soundtrack tab and overlays.Tests
pytest -qpasses, 459 tests. New ones include:npm test(98 tests) and build pass. New tests cover the overlay helpers, the anchor value round-trip, the editor timing a lower third to a line and a later scene, credits on and off, and Save to GAM to the In GAM link.🤖 Generated with Claude Code
https://claude.ai/code/session_016fiRJAt34ag62iPiuMkNhm
Generated by Claude Code