use MemoryPool instead of allocator, fix examples#1
Open
zxcv05 wants to merge 2 commits into
Open
Conversation
Owner
|
Sorry, life got in the way and github is not really all that great at notifying people on PRs. This looks good, I'll do some testing/playing around with this today, run some benchmarks and if it's all positive merge it into main. Appreciate it :) |
Owner
|
@zxcv05 had some time to play around with this, I have some thoughts. I like where you're going with this. That said, I can't merge it yet
What needs fixing/attention:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryPool is more performant and efficient than using a generic allocator, especially for lots of
create()s anddestroy()s of only a single type (Node(K, V, D)in this case)also refactored part of the BPlusTree struct for easier readability and nicer qualities like
BPlusTree(K, V, D).Nodeinstead of having detachedBPlusTree(K, V, D)andNode(K, V, D)(they are intrinsically linked)