Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Dec 5, 2025

Proposed changes

We need to run this optimization within the same node script because we deactivated node lifecycle scripts.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/refactor-mitigate-deactivated-node-lifecycle-scripts

@mfranzke mfranzke self-assigned this Dec 5, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Dec 5, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in UX Engineering Team Backlog Dec 5, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

⚠️ No Changeset found

Latest commit: 929801f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mfranzke mfranzke enabled auto-merge (squash) December 5, 2025 14:26
@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Dec 5, 2025
@mfranzke mfranzke requested a review from Copilot December 5, 2025 14:26
Copilot finished reviewing on behalf of mfranzke December 5, 2025 14:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the foundations package to consolidate icon overview generation and formatting into a single script execution, addressing the repository's use of --ignore-scripts during installation which prevents automatic lifecycle hook execution.

  • Combines the postcopy-prepare:icon-overview script with copy-prepare:icon-overview to run prettier formatting inline
  • Removes the now-redundant postcopy-prepare:icon-overview script that was previously triggered via lifecycle hooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🎁 Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants