Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container, image and network names mixed two styles. Names written by hand used underscores (
quotient_server,quotient_redis,quotient_database,quotient_network). Names Compose generates use hyphens (quotient-runner,quotient-divisor, and containers likequotient-runner-1). That made it easy to type the wrong one indocker logs,docker execand similar commands.This switches the hand-written names to hyphens:
docker-compose.yml:quotient-server,quotient-redisandquotient-database;quotient-server;quotient-network, also indocker-compose.base.yml.engine/engine.goandrunner/runner.gois nowquotient-redis:6379. Container names double as hostnames on the Compose network, so this default has to match the container..env,README.mdandconfig/event.conf.exampleuse the new database and Redis hostnames.Volumes (
db_data,redis_data) are unchanged so existing installs keep their data.Upgrading an existing deployment
docker compose up -drecreates the renamed containers. The data volumes are unchanged, so nothing is lost.POSTGRES_HOST,DBConnectURLorREDIS_ADDRto the old names in their own.envorevent.confneeds to update them.docker logs quotient_serveror similar need the new names.docker network rm <project>_quotient_network.divisor/README.mdstill mentionsquotient_redis. The divisor is a separate repository, so that needs its own change.Unit tests pass and
docker compose configvalidates.