Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The authentication middleware stores the caller three times on the request context: as an
Identity(typed key), and again under the plain string keys"username"and"roles". Its comment says the string keys should go once every handler readsIdentity. This finishes that.CallerRoles(ctx), which returns the caller's roles, or nil for an anonymous request.Value("roles")/Value("username")(announcements, api, authentication, graphs, identity, injects, pcrs, services, frontend, logging middleware) now usesCallerRolesorIdentityFrom.Identity. The twonolint:staticcheckcomments for string context keys go with it.Behavior is unchanged with one exception: handlers that did a bare
Value("roles").([]string)would panic if reached without an identity, and now see no roles instead.pageDatastill leavesusernameunset for anonymous requests.page.htmlchecks{{ if ne .username nil }}, and an empty string there would render the page as logged in.Tests: added
TestCallerRoles. The test helperrequestAsnow sets roles on theIdentity, as the middleware does. Unit tests pass with-race, and golangci-lint is clean.