Skip to content

Comments

Fix missing keepalives in \e prompt loop#1612

Merged
rolandwalker merged 1 commit intomainfrom
RW/keepalive-in-editor-prompt-loop
Feb 24, 2026
Merged

Fix missing keepalives in \e prompt loop#1612
rolandwalker merged 1 commit intomainfrom
RW/keepalive-in-editor-prompt-loop

Conversation

@rolandwalker
Copy link
Contributor

Description

Fix missing keepalives in \e prompt loop by passing the inputhook value to handle_editor_command().

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Feb 23, 2026
@github-actions
Copy link

Findings: none (no correctness or security issues spotted).

Test gap:

  1. mycli/main.py: There’s no test that handle_editor_command() forwards inputhook to PromptSession.prompt(). A small unit test with a mocked PromptSession would prevent regressions around keepalive behavior in the editor loop.

Open questions/assumptions:

  • I assumed PromptSession.prompt(inputhook=...) accepts None (current usage elsewhere suggests it does).

If you want, I can draft that test.

by passing the inputhook value to handle_editor_command()
@rolandwalker rolandwalker force-pushed the RW/keepalive-in-editor-prompt-loop branch from 3c7a98f to de06101 Compare February 24, 2026 09:49
@rolandwalker rolandwalker merged commit 7da8ac1 into main Feb 24, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/keepalive-in-editor-prompt-loop branch February 24, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants