fix: escape embedded closing braces in pyodbc connection string values#734
Merged
axellpadilla merged 1 commit intoJul 3, 2026
Merged
Conversation
The pyodbc branch of format_connection_string_value wrapped values in
braces without doubling embedded closing braces, so a password like
pa}ss produced PWD={pa}ss} and the driver misparsed the rest of the
connection string. The mssql-python branch already escaped correctly.
Double the closing brace per the ODBC quoting rules and cover both
backends with unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Connection string values for the pyodbc backend are wrapped in braces, for example
PWD={my-password}. If the value itself contains a closing brace (say a password likepa}ss), the driver treats that}as the end of the value and misparses the rest of the connection string, so the connection fails.Fix
Inside a brace-quoted ODBC value, a literal
}must be written as}}.format_connection_string_value()now doubles closing braces before wrapping the value. The mssql-python path is unchanged; its helper (escape_connection_string_value) already escaped braces this way.Testing
None, and delegation to the mssql-python helper.