add option to make diagnostics bundle to pytest plugin#39
Open
margaret wants to merge 9 commits intodcos:masterfrom
Open
add option to make diagnostics bundle to pytest plugin#39margaret wants to merge 9 commits intodcos:masterfrom
margaret wants to merge 9 commits intodcos:masterfrom
Conversation
6 tasks
mellenburg
reviewed
Mar 22, 2018
| USER_HOME_DIR = os.path.join(os.path.expanduser('~')) | ||
|
|
||
|
|
||
| def order_fixtures(metafunc): |
There was a problem hiding this comment.
I'm fine with this but we need to remove https://github.com/dcos/dcos/blob/master/packages/dcos-integration-test/extra/conftest.py#L22
and
https://github.com/dcos/dcos/blob/master/packages/dcos-integration-test/extra/conftest.py#L17
and also refactor the one place that is used, which is here:
https://github.com/dcos/dcos/blob/master/packages/dcos-integration-test/extra/test_composition.py#L19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As much as I don't like adding hacks, the diagnostics fixture needs to run last, and this seems like a better hack than the current one where the fixture name has an underscore prepended to make it first alphabetically.
https://jira.mesosphere.com/browse/QUALITY-1978