⚡ Bolt: Cache FAQs YAML load to improve UI rendering performance#556
⚡ Bolt: Cache FAQs YAML load to improve UI rendering performance#556alinelena wants to merge 1 commit into
Conversation
Co-authored-by: alinelena <3306823+alinelena@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Created a new module-level function
load_faq_datausing@functools.cacheto handle reading and parsingfaqs.yml. Thebuild_faqsfunction now uses a deep copy of this cached data rather than directly opening and reading the YAML file on every execution.🎯 Why: Running
yaml.safe_loadsynchronously is a slow operation, taking roughly 5ms per call. While it seems small, executing this every time the FAQ component needs to build introduces unnecessary overhead. This is the exact same optimization applied previously tomodels.ymlandframeworks.yml.📊 Impact: Reduces disk I/O and CPU parsing overhead to practically 0 for subsequent renders of the FAQs section within the same Python process.
🔬 Measurement:
uv run python3 -m timeit -s "import yaml; from pathlib import Path; p=Path('ml_peg/app/utils/faqs.yml')" "with open(p, encoding='utf8') as f: yaml.safe_load(f)"yields ~5ms. Caching entirely skips this parsing phase. Tested via a temporary mocking script to ensure UI generation succeeds smoothly without regressions.PR created automatically by Jules for task 5980448929695363578 started by @alinelena