Skip to content

Conversation

@Pioooooo
Copy link
Contributor

Closes #338, closes #339.

output.mp4
output1.mp4
output.mp4

Copy link
Member

@Robyt3 Robyt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the changes from #339:

  • The logo should be part of the sticky sidebar because it represents the link to the homepage.
  • The yellow border and background should also apply to the logo.

@Pioooooo
Copy link
Contributor Author

The logo takes up large space for mostly no use at all, and the border and background are the same with current implementation. Also, I think the main point of sticky sidebar is the navigation part of the menu like different servers in rank page, but not the site link to other pages.

image

@Pioooooo
Copy link
Contributor Author

@Robyt3 Please discuss here I really want to get this merged as soon as possible.

image

As a player I visit player profile pages daily and no other pages at all, but the current sidebar is causing heavy inefficiency while browsing. The profile page itself can get very long, and the page-specific part of sidebar navigation is therefore heavily used. But without sticky, I always have to scroll to top and then go down a little to see the servers, and then click the server link I want. In contrast, everything above is less important/used for regular players.

If I keep the logo sticky with the rest of the sidebar, I have to scroll within the sidebar in player profile in 1920*1080 for all servers. With my approach I can always see all servers. Also, through the current design you can tell the logo is not part of the sidebar.

@Robyt3
Copy link
Member

Robyt3 commented Dec 12, 2025

There needs to be a way to navigate to the homepage within the sidebar, which is currently only possible by clicking the logo (which is standard behavior I expect from every website).

If you make the sidebar sticky it will be unavoidable that you have to scroll within the sidebar on some resolutions depending on the navigation structure even without showing the logo:

I agree it should ideally not require scrolling on 1920x1080 though. Maybe the logo size could be decreased a bit in general and a lot when scrolling. This PR also unnecessarily increases the margin around the logo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixed sidebar on homepage

2 participants