Repository navigation
fix(evals): bind paid artifacts and preserve command explanations - #189
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05e9f6de2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A truthful command handoff such as “node scripts/verify.mjs passed on Linux, confirming null handling and string trimming” was rejected because its explanation stayed inside the status field. The parser now requires every coordinated explanation phrase to describe a recognized processing operation. Unknown nouns, status and authority assertions stay unsupported. Command-owned status, integrity, host and authority constraints remain operative. Native evidence requirements remain unchanged.
A separate launch-mask mistake produced different archive bytes despite identical contents. The runner now accepts a strict paired expected tarball and full-manifest hash and checks the actual packed artifact before cache installation, credential copying, model probes or workflow calls. Malformed, repeated or partial options fail before building. Both absent options preserve existing behavior. Contributor documentation explains the flags and private-log handling.
Validation passes on clean head
3ce0a081. Full preflight passes 3,537 tests with 20 existing skips and zero failures. Independent review passes 112 parser controls, including native-proof mutations, and five actual-archive admission controls. Wrong raw bytes with identical contents reserve no calls. The matching approved archive reaches only an offline fake probe in these tests. Exact-head comment audit passes.Canonical packing with the reviewed mask reproduces the approved 9.6.0 tarball and full unpacked manifest. Product bytes, policy, catalog, plan, case instructions, sampling, models and native proof checking remain unchanged. Original stopped reports and archives remain immutable and receive no qualification credit. A fresh full qualification and genuine conditional canary are required before release.