Repository navigation
fix: plan returns missing references as a typed list - #12
Merged
Merged
Conversation
A plan blocked by the spec put `[e.as_dict() ...]` as a Python repr inside `detail`. It now returns `resolution_errors`, the same list check and apply return (column_not_found carries `candidates`), and `detail` is a short sentence. Exit codes and the other fields are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item C from the 0.2.0 triage.
Before: a plan blocked by missing references returned
"detail": "target spec has referential errors: [{'code': 'column_not_found', ...}]", a Python repr no script could parse.After:
planreturnsresolution_errors, the same typed listcheckandapplyreturn (column_not_foundcarriescandidatesfrom #11), anddetailreads "the spec names 2 things this instance doesn't have; see resolution_errors". Exit codes, the other fields, andblockedfor a slug Chartwright didn't build are unchanged.Tests: three offline cases in
tests/test_plan_errors.py(each fails on main). No live-specific behaviour: the references come from the same resolver the live check exercises.Offline suite: 357 passed.