Skip to content

Decompile names the per-chart settings it still dropped silently - #37

Merged
debabsah merged 1 commit into
mainfrom
fix/decompile-silent-drops-2
Oct 5, 2026
Merged

debabsah merged 1 commit into
mainfrom
fix/decompile-silent-drops-2

Conversation

@debabsah

@debabsah debabsah commented Oct 5, 2026

Copy link
Copy Markdown
Owner

This is a sibling of #28. The fact-check of the refreshed docs (PR #9) changed one setting at a time on compiled bundles. About twenty chart settings came back from decompile with no spec change and no loss: a silent drop, the same gap #28 closed for other settings.

The fix

Each of those settings now has the value an untouched chart of its type stores, added to _STORED_DEFAULTS. Every value was read from the plugin source at 4.1.4, 5.0.0 and 6.1.0:

  • BigNumber: font sizes, and the trendline toggle;
  • Timeseries DEFAULT_FORM_DATA: seriesType line, orientation vertical;
  • Pie: radii 30 and 70, labels shown;
  • Funnel: labels shown, tooltip label KeyValuePercent = 5, percentages from the first step;
  • Treemap: labels shown;
  • Heatmap: axis sort alpha_asc at 4.1.4 and unset at 5.0.0 and 6.1.0, margins auto, label intervals -1, unbounded values, continuous legend;
  • Histogram: normalize off;
  • currency format: no default, so an empty or all-null value counts as unset.

A pie's inner radius counts only on a donut. The compile round trip from #28 still keeps any value the spec writes back from being reported.

Effect

  • Probe: re-running the fact-check's probe, every setting it found silent is now named. What stays silent either equals the compiled value or has no effect on its own, such as marker size with markers off or a series sort with no series limit.
  • Real UI export: on the Featured Charts fixture (25 charts), no new losses; still only the funnel's legendMargin=50 from Decompile names the settings it drops instead of dropping them silently #28.

Checks

  • Offline: 1563 passed, 1 skipped. There are 12 new parametrized cases, one per setting family, plus a test that an empty currency format is no loss.
  • Live (by hand on 6.1.0): adopt and the kitchen-sink apply pass.

Once this merges, PR #9's LIMITS "drops without a note" list shrinks back to the dashboard metadata that adopt lists.

The fact-check of the 0.5.0 docs found about twenty chart settings decompile discarded silently (pie radius and labels, step or smooth lines, a hidden trendline, funnel and treemap labels, heatmap sort, margins, intervals and bounds, histogram normalize, currency format). Each now has its untouched-chart default in _STORED_DEFAULTS, read from the plugin source at 4.1.4, 5.0.0 and 6.1.0; the compile round trip still keeps any value the spec writes back from being reported.
@debabsah
debabsah merged commit 584df7f into main Oct 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant