Repository navigation
Decompile names the per-chart settings it still dropped silently - #37
Merged
Merged
Conversation
The fact-check of the 0.5.0 docs found about twenty chart settings decompile discarded silently (pie radius and labels, step or smooth lines, a hidden trendline, funnel and treemap labels, heatmap sort, margins, intervals and bounds, histogram normalize, currency format). Each now has its untouched-chart default in _STORED_DEFAULTS, read from the plugin source at 4.1.4, 5.0.0 and 6.1.0; the compile round trip still keeps any value the spec writes back from being reported.
debabsah
added a commit
that referenced
this pull request
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sibling of #28. The fact-check of the refreshed docs (PR #9) changed one setting at a time on compiled bundles. About twenty chart settings came back from decompile with no spec change and no loss: a silent drop, the same gap #28 closed for other settings.
The fix
Each of those settings now has the value an untouched chart of its type stores, added to
_STORED_DEFAULTS. Every value was read from the plugin source at 4.1.4, 5.0.0 and 6.1.0:DEFAULT_FORM_DATA:seriesTypeline,orientationvertical;alpha_ascat 4.1.4 and unset at 5.0.0 and 6.1.0, margins auto, label intervals -1, unbounded values, continuous legend;A pie's inner radius counts only on a donut. The compile round trip from #28 still keeps any value the spec writes back from being reported.
Effect
legendMargin=50from Decompile names the settings it drops instead of dropping them silently #28.Checks
Once this merges, PR #9's LIMITS "drops without a note" list shrinks back to the dashboard metadata that
adoptlists.