Repository navigation
Conversation
…ed empty IN values Gaps a design review found while building a showcase dashboard, each checked in plugin source at 4.1.4, 5.0.0 and 6.1.0: - Trendline KPI: `y_axis_truncate` unticks "Start y-axis at 0" (start_y_axis_at_zero, BigNumberWithTrendline/controlPanel.tsx:96 at 4.1.4 and 5.0.0, :107 at 6.1.0), which the trendline reads as yAxis.scale: !startYAxisAtZero (transformProps.ts:219, :326 at 6.1.0). A trailing-12-month total that moved a few percent was a flat line over a solid block; fitted, it shows the movement. Omitted, it compiles to true as before, so the goldens are unchanged; decompile reads false back as the field and plan reports a change made in the UI. All three releases declare it: no version gate. - Design brain 10: no page-size picker, pager or search box on a table whose rows all show in its panel. Any page_length above 0 draws the picker, on one page too (hasPagination, DataTable.tsx:123, :173 at 6.1.0). default.search-box now fills only a raw table that pages, where the box sits in the picker's bar, and --fix removes a box it filled over rows that all show; size.table-chrome, a new info rule, names an author's page_length or search_box there. - Apply's data check names the values a chart's IN filter lists that return no rows, on a column the chart groups or draws by (a line chart listing four zones where two have data). A time column and a series-limited groupby are left alone, and a query that reached its row limit says so. No spec field where the plugin has no control, documented instead (spec descriptions, CONTRACTS.md, the chart-choice guide): - A mixed chart draws every line solid at one width: transformSeries takes a line style only from its caller, and MixedTimeseries passes none for either query at any of the three releases. 6.1.0's ECharts Options replace the series list whole and a theme override styles every series, so neither reaches one series. A reference series goes in its own query with a pale label_colors colour. - The area chart declares a fill opacity (already `opacity`) but no line width; on 6.1.0 a theme's echartsOptionsOverridesByChartType can thin every area chart's edges (read from source, not tried live). - Line, bar, area and scatter charts have one number format for the value axis, the value labels and the tooltip; a `~` format such as ",.1~f" keeps the axis in whole numbers. A mixed chart writes query B's value labels in number_format_secondary whichever axis B sits on. Verified live on 4.1.4, 5.0.0 and 6.1.0 with throwaway dashboards: apply, re-apply with stable ids, plan clean, decompile without losses, screenshots of each look and the data check naming an empty deal size. The display-controls live check passes on 6.1.0 with the fixture's new field.
This was referenced Oct 5, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes found while building a showcase dashboard, plus the limits behind three more, each verified in Superset source at 4.1.4, 5.0.0 and 6.1.0. Stacked on #40.
Added
y_axis_truncateonbig_number_trend. It writesstart_y_axis_at_zero: false, so the trendline fits its data. Without it, a trailing-12-month total that moves 3% renders as a flat line over a solid block. The control is atBigNumberWithTrendline/controlPanel.tsx:96at 4.1.4 and 5.0.0 and:107at 6.1.0, read asyAxis.scale(transformProps.ts:219,326at 6.1.0), on every release. Omitted, the compiler still writestrue, so specs build the same bytes. Decompile andplanread it.page_lengthabove 0 draws the page-size picker even when every row fits (DataTable.tsx:123,173at 6.1.0).default.search-boxnow fills only on a table that pages.--fixremoves a box an older brain filled on a table whose rows all show.size.table-chrome, names apage_lengthorsearch_boxwritten on such a table.INvalue, on a column the chart groups or draws by, returns no rows. For example:deal_size IN lists 'Huge', which returns no rows, so the chart draws nothing for it.Documented as limits (no plugin control exists)
transformProps.ts:457-493,530-567at 6.1.0). A theme override styles every series alike. The workaround is the reference metric in its own query, pale throughlabel_colors.y_axis_formatserves all three.",.1~f"gives whole-number ticks while keeping decimals on values.opacity.Design brain 10
PRs #40 and #42 each claim "9", and #38 "8", so the numbers need reconciling at merge.
Tests
params_drift --allis clean, and every example and fixture without the new field compiles to the same bytes.planclean, screenshots. On 6.1.0,ci_live_checkpassed with the display-controls fixture.