fix: preserve existing namespaces on enable() call - #1055
Open
yunaremaia wants to merge 1 commit into
Open
Conversation
Previously, calling `enable()` would reset the `names` and `skips`
arrays, clearing any namespaces that were previously enabled.
This caused behavior where `debug.enable('bar')` after `DEBUG=foo`
would silently disable the 'foo' namespace, surprising users who
expected both to be active.
The fix makes `enable()` merge namespaces instead of replacing
them. Empty/null/undefined still resets (for `disable()` compatibility).
Fixes debug-js#425
Author
|
CI hasn't been triggered yet on this PR. Could you re-run the workflow or let me know if there's anything I need to do to trigger CI checks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, calling
enable()would reset thenamesandskipsarrays, clearing any namespaces that were previously enabled.This caused behavior where
debug.enable('bar')afterDEBUG=foowould silently disable thefoonamespace, surprising users who expected both to be active.The fix makes
enable()merge namespaces instead of replacing them. Empty/null/undefined still resets (fordisable()compatibility).Fixes #425