-
Notifications
You must be signed in to change notification settings - Fork 2
restore _GLIBCXX_DEBUG_BACKTRACE support in testing #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis update revises the test/CMakeLists.txt file to update the copyright notice and add a new conditional block for GNU compilers. Within that block, it conditionally includes a configuration file to detect and enable GLIBCXX debug backtrace support. The accompanying test/glibcxx_debug_backtrace.cmake file systematically attempts various compilation configurations to check for the feature and sets corresponding variables, issuing a warning if no working configuration is found. Changes
Sequence Diagram(s)sequenceDiagram
participant BS as Build System
participant CL as CMakeLists.txt
participant DBG as glibcxx_debug_backtrace.cmake
participant COMP as Compiler Tester
BS->>CL: Start Build
CL->>CL: Check for GNU Compiler
alt Using GNU
CL->>DBG: Include debug backtrace config
DBG->>COMP: Attempt compile (default configuration)
alt Default succeeds
DBG->>CL: Set debug backtrace support
else Default fails
DBG->>COMP: Attempt compile with C++23
alt C++23 succeeds
DBG->>CL: Set debug backtrace support
else C++23 fails
DBG->>COMP: Attempt compile with libstdc++exp
alt libstdc++exp succeeds
DBG->>CL: Set debug backtrace support
else libstdc++exp fails
DBG->>COMP: Attempt compile with libstdc++_libbacktrace
alt libstdc++_libbacktrace succeeds
DBG->>CL: Set debug backtrace support
else All fail
DBG->>BS: Issue warning for missing support
end
end
end
end
else Not GNU
CL->>BS: Proceed with default configuration
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
I can't be bothered maintaining this. Might move it to https://github.com/decodeless/writer or somewhere where it would be more useful in integration testing |
Summary by CodeRabbit