Skip to content

windows support and mappedfile tests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pknowles wants to merge 3 commits into
base: main
Choose a base branch
from
Open

windows support and mappedfile tests #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3d286f
windows support
pknowles May 6, 2025
346b8fe
mapped memory tests
pknowles May 6, 2025
bed6295
add mappedfile linear resize tests
pknowles May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,21 @@ FetchContent_MakeAvailable(nanobench)
FetchContent_Declare(
decodeless_offset_ptr
GIT_REPOSITORY https://github.com/decodeless/offset_ptr.git
GIT_TAG 1f87a9d7a8be23b90c06124014f286df91562006
GIT_TAG 38ceefc6ce63fb4667cd207424b1277c3eed5f8d
GIT_SHALLOW TRUE)
FetchContent_MakeAvailable(decodeless_offset_ptr)

FetchContent_Declare(
decodeless_mappedfile
GIT_REPOSITORY https://github.com/decodeless/mappedfile.git
GIT_TAG 6550dc283b3a01de1c0d02c79bfd6422812d70e8
GIT_SHALLOW TRUE)
FetchContent_MakeAvailable(decodeless_mappedfile)
Comment on lines +32 to +37
Copy link

@coderabbitai coderabbitai bot May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add missing decodeless_mappedfile to target_link_libraries.

The new dependency decodeless_mappedfile is correctly declared and fetched, but not linked with the decodeless_benchmark target. Since the benchmark code uses types like decodeless::resizable_file and decodeless::resizable_memory from this library, it should be added to the target_link_libraries section.

target_link_libraries(decodeless_benchmark PRIVATE
    decodeless::writer
    decodeless::offset_ptr
+   decodeless::mappedfile
    gtest_main
    nanobench
    )
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
FetchContent_Declare(
decodeless_mappedfile
GIT_REPOSITORY https://github.com/decodeless/mappedfile.git
GIT_TAG 6550dc283b3a01de1c0d02c79bfd6422812d70e8
GIT_SHALLOW TRUE)
FetchContent_MakeAvailable(decodeless_mappedfile)
target_link_libraries(decodeless_benchmark PRIVATE
decodeless::writer
decodeless::offset_ptr
decodeless::mappedfile
gtest_main
nanobench
)
🤖 Prompt for AI Agents (early access) 
In CMakeLists.txt around lines 32 to 37, the decodeless_mappedfile dependency is
fetched but not linked to the decodeless_benchmark target. To fix this, add
decodeless_mappedfile to the target_link_libraries command for
decodeless_benchmark so the benchmark target correctly links against this
library and can use its types.


FetchContent_Declare(
decodeless_writer
GIT_REPOSITORY https://github.com/decodeless/writer.git
GIT_TAG af57ca839694a7f3ca70afdfb8bab3420ad833cf
GIT_TAG 2afa7104b986e52031b0969f30512d7995623a84
GIT_SHALLOW TRUE)
FetchContent_MakeAvailable(decodeless_writer)

Expand Down
Loading