Skip to content

rpcclient: Authorization header is only needed by AuthTypeBasic #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajohi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rpcclient: Authorization header is only needed by AuthTypeBasic #3586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions rpcclient/infrastructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,12 +1295,15 @@ func dial(config *ConnConfig) (*websocket.Conn, error) {
dialer.NetDial = proxy.Dial
}

// The RPC server requires basic authorization, so create a custom
// request header with the Authorization header set.
login := config.User + ":" + config.Pass
auth := "Basic " + base64.StdEncoding.EncodeToString([]byte(login))
requestHeader := make(http.Header)
requestHeader.Add("Authorization", auth)
var requestHeader http.Header
Copy link
Member

@jrick jrick Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is nil ok?

Copy link
Member

@jrick jrick Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, since reads of a nil map is allowed.

if config.AuthType == AuthTypeBasic {
// The RPC server requires basic authorization, so create a custom
// request header with the Authorization header set.
login := config.User + ":" + config.Pass
auth := "Basic " + base64.StdEncoding.EncodeToString([]byte(login))
requestHeader = make(http.Header)
Copy link
Member

@jrick jrick Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed or does Add handle the nil receiver?

if it is needed, it seems like the nil variable is really not ok anywhere.

Copy link
Member

@jrick jrick Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed, but this seems fine due to go's map semantics and how reads of nil maps is ok, but writes are not.

requestHeader.Add("Authorization", auth)
}

// Dial the connection.
url := fmt.Sprintf("%s://%s/%s", scheme, config.Host, config.Endpoint)
Expand Down
Loading