Verify derived plan steps follow changes to their premises - #898
Merged
Merged
Conversation
…related steps Signed-off-by: dada-yan <BinjunYann@gmail.com>
This was referenced Sep 24, 2026
Closed
Maya-Kid
force-pushed
the
test/premise-replay
branch
from
September 24, 2026 09:12
9ebab2c to
8000623
Compare
Maya-Kid
marked this pull request as ready for review
September 24, 2026 09:13
WaylandYang
approved these changes
Sep 24, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Useful regression coverage on the real store path, and the docstring is honest that it exercises existing APIs with explicit reconciliation rather than the automatic loop (#899 and #900 remain open). Two optional suggestions: split the first test's seven phases so a failure in one does not hide the others, and note in the observe helper that it mirrors pending::confirm's ordering so drift is caught by a reader. LGTM.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plan step represented by a business-rule conclusion should follow changes to its factual premises without changing unrelated conclusions. Add three real PostgreSQL store tests for that contract:
All three tests run normally on
dev; there are no newly ignored tests and no production changes or dependencies on #884, #896 or #897. They exercise existing store APIs and explicitly supplied alignment/reconciliation, not an automatic ingestion-to-decision loop.Validation:
8000623, based ondev@9f50e3c: Rust format, strict workspace/all-target Clippy and the PostgreSQL 16/pgvector workspace suite passed (1,081 passed, 0 failed, 5 existing ignored).UTOPIA_TEST_REQUIRE_DB=1was set and all three new passing test names were verified. The unavailable PDF fallback utility limits that unrelated coverage.Run against a migrated, dedicated PostgreSQL/pgvector database:
UTOPIA_TEST_REQUIRE_DB=1 cargo test --locked -p utopia-store --test store \ a_plan_step_follows_its_premise -- --test-threads=1Set
UTOPIA_DATABASE_URLfor that database. The HTTP replay and its version-specific assertions remain experimental evidence on the fork, outside this PR. The two proposed-behavior gaps and executable reproductions are tracked separately in #899 and #900.Refs #875.