Fix zero/division safety gaps in utility and inference paths#7855
Draft
harshang03 wants to merge 1 commit into
Draft
Fix zero/division safety gaps in utility and inference paths#7855harshang03 wants to merge 1 commit into
harshang03 wants to merge 1 commit into
Conversation
Add explicit validation for divisor inputs in groups and inference utilities, enforce valid throughput report intervals, and reject invalid HPU dequantization scales to avoid ZeroDivisionError and silent inf/nan propagation.
liuyun7345
added a commit
to liuyun7345/DeepSpeed
that referenced
this pull request
Jul 12, 2026
Prevent ZeroDivisionError and silent non-finite propagation at four reported sites: 1. groups._ensure_divisibility: reject denominator == 0 before modulo 2. ThroughputTimer: reject non-positive steps_per_output at init and report-boundary time 3. inference_utils.ceil_div: reject divisor == 0 4. HPU FPQuantizer.dequantize: reject zero/non-finite scales before 1/scale Adds focused unit tests covering each failure mode. Picks up the inactive draft deepspeedai#7855. Fixes deepspeedai#7838 Signed-off-by: liuyun7345 <liuyun7345@sina.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
ceil_div.steps_per_outputvalidation inThroughputTimerso invalid values fail early instead of triggering modulo-by-zero at runtime.Screenshot or video (only for visual changes)
GitHub Issue Link (if applicable)
Testing Plan
./.venv/bin/python -m pytest tests/unit/utils/test_groups.py tests/unit/utils/test_timer.py tests/unit/inference/test_inference_utils.py tests/unit/ops/fp_quantizer/test_fp_quantizer_scale_validation.pyContribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.