docs(sparse_attention): fix copy-pasted BigBird return line in sliding-window layout - #8448
Open
simpleqt wants to merge 1 commit into
Open
docs(sparse_attention): fix copy-pasted BigBird return line in sliding-window layout#8448simpleqt wants to merge 1 commit into
simpleqt wants to merge 1 commit into
Conversation
…g-window layout LocalSlidingWindowSparsityConfig.make_layout builds a sliding-window layout, but its Return line was copied verbatim from BigBirdSparsityConfig.make_layout and claims a BigBird layout. Signed-off-by: simpleqt <89645338+simpleqt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalSlidingWindowSparsityConfig.make_layoutbuilds a sliding-window sparsity layout (viaset_sliding_window_layout), but itsReturn:line was copied verbatim fromBigBirdSparsityConfig.make_layoutand claims to return aBigBirdlayout. The line now names the layout this class actually produces. Docs-only.Signed-off-by: simpleqt 89645338+simpleqt@users.noreply.github.com