Skip to content

fix: keep the wrapped cause in NotFound and PermissionDenied messages #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
basgys wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: keep the wrapped cause in NotFound and PermissionDenied messages #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions faults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ type MissingFailure struct {
}

func (e *MissingFailure) Error() string {
return "resource not found"
return maybeWrap(e.error, "resource not found").Error()
}

func (e *MissingFailure) Is(target error) bool {
Expand All @@ -508,7 +508,7 @@ type PermissionFailure struct {
}

func (e *PermissionFailure) Error() string {
return "permission denied"
return maybeWrap(e.error, "permission denied").Error()
}

func (e *PermissionFailure) Is(target error) bool {
Expand Down
10 changes: 10 additions & 0 deletions faults_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,16 @@ func TestErrorMessage(t *testing.T) {
err: faults.WithResourceExhausted(cause),
wantMsg: "quota failure: underlying issue",
},
{
scenario: "WithNotFound wrapping a cause includes the cause in the message",
err: faults.WithNotFound(cause),
wantMsg: "resource not found: underlying issue",
},
{
scenario: "WithPermissionDenied wrapping a cause includes the cause in the message",
err: faults.WithPermissionDenied(cause),
wantMsg: "permission denied: underlying issue",
},
}

for _, tt := range tests {
Expand Down
Loading