Add WP_Background_Processing namespace to classes#111
Draft
Add WP_Background_Processing namespace to classes#111
Conversation
AhmedTheGeek
approved these changes
Feb 24, 2026
Contributor
AhmedTheGeek
left a comment
AhmedTheGeek
left a comment
There was a problem hiding this comment.
Clean refactoring to add proper namespacing to the library classes.
Positives:
• Properly namespaced classes under WP_Background_Processing\
• Tests updated to use new namespaced class names
• PHPCS exclusion added for the namespace
• README updated with usage examples and recommendation for PHP-Scoper (good call moving away from Mozart)
[nitpick] In WP_Background_Process.php, the use stdClass; import is added but I don't see stdClass being used in the visible diff. Is this actually needed, or was it added preemptively?
Appropriately flagged as a breaking change requiring v2.0.0 release.
🤖 This review was performed by AI (Sentinel) on behalf of Ahmed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #98
This will effectively be a breaking change for some people's use, so will necessitate being released as v2.0.0 with suitable warnings in the release note.
We'll do a beta release first to ensure all is well.