Match engine image to CLI version#124
Merged
Merged
Conversation
The CLI now launches an engine image whose tag is derived from the CLI's own version instead of Docker's implicit :latest, so a vX.Y.Z CLI runs the vX.Y.Z engine and does not silently drift when a new release is published. - buildinfo.IsRelease() distinguishes clean release builds from dev builds; the Makefile dev-marks local/non-tag builds (<ver>-dev+<sha>) and the release workflow passes VERSION explicitly so release binaries stay clean. - constants.EffectiveSptImage() resolves $SPT_IMAGE > :v<version> (release) > :spt_dev (dev); there is no fallback to :latest, so a missing release tag fails loudly rather than running a different engine version. - Dev images (spt_dev) auto-skip the registry pull across the command, preflight, and TUI paths, with a helpful "make docker-local" error when the image is absent. - Add --spt-image flag (precedence: flag > SPT_IMAGE env > version default). - Tests for the new behavior + README "Engine image selection" section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary