Repository navigation
ci: trigger builds on pull_request events - #47
Merged
Merged
Conversation
Add pull_request to the build_on_push workflow trigger so PRs from forks (e.g. first-time contributors) queue CI runs. Previously only push and workflow_dispatch triggered the workflow, so fork PRs had no checks to approve or run at all. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR checks were not running for pull requests from forks (e.g. #46), including no "approve and run" prompt at all.
Root Cause
None of the repository's workflows listened for the \pull_request\ event:
Since fork PRs don't generate a \push\ event on this repository, there was nothing queued for GitHub to prompt approval on.
Fix
Add \pull_request\ to the \build_on_push.yaml\ trigger list, so PRs (including from forks/first-time contributors) queue CI runs and surface the normal workflow-approval prompt for maintainers.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com