-
Notifications
You must be signed in to change notification settings - Fork 663
refactor(async): improve retry() input validation #6922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6922 +/- ##
=======================================
Coverage 94.17% 94.18%
=======================================
Files 584 584
Lines 43087 43102 +15
Branches 6875 6883 +8
=======================================
+ Hits 40578 40596 +18
+ Misses 2457 2455 -2
+ Partials 52 51 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We have the policy of accepting a new feature to stable APIs as unstable feature first. See https://github.com/denoland/std/blob/main/.github/CONTRIBUTING.md#new-features-in-stable-packages-version--100 Can you move feature addition part of this change to a different PR, targeting |
2cadea6 to
372e12b
Compare
Sorry, I should have considered that! I've reverted the new feature, while still keeping delay() instead of setTimeout. I hope this is acceptable (it allows retry to handle very large timeouts correctly) |
kt3k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Switched to using delay() for timeout handling.
Input handling: