Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
EntityExplorer の updateAll において、多重度複数プロパティに対する更新指定を拡張し、配列一括指定(ARRAY)および配列要素のインデックス指定(ARRAY_INDEX)による更新を可能にするPRです。管理コンソールUIとツール側サービスの双方に指定形式の追加が入っています。
Changes:
- updateAll の値指定種別に
ARRAY/ARRAY_INDEXを追加し、配列更新用の値構造(配列要素の valueType/index/value)を導入 - サーバ側(EntityToolService)で多重度複数プロパティの一括更新・インデックス更新を
UpdateConditionに反映 - 管理コンソール(EntityUpdateAllDialog)で UI 入力(配列編集グリッド等)と送信データ構造を拡張
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/UpdateAllValue.java | updateAll値指定に配列指定を表現するデータ構造(ARRAY/ARRAY_INDEX、配列要素)を追加 |
| iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/EntityToolService.java | updateAllで配列一括/インデックス更新を組み立てるロジックと型変換ヘルパを追加 |
| iplass-admin/src/main/java/org/iplass/adminconsole/client/tools/ui/entityexplorer/datalist/EntityUpdateAllDialog.java | updateAll編集UIに配列編集(グリッド)と表示サマリ、送信値(arrayValues)を追加 |
iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/EntityToolService.java
Outdated
Show resolved
Hide resolved
iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/EntityToolService.java
Outdated
Show resolved
Hide resolved
...a/org/iplass/adminconsole/client/tools/ui/entityexplorer/datalist/EntityUpdateAllDialog.java
Outdated
Show resolved
Hide resolved
...a/org/iplass/adminconsole/client/tools/ui/entityexplorer/datalist/EntityUpdateAllDialog.java
Outdated
Show resolved
Hide resolved
iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/EntityToolService.java
Outdated
Show resolved
Hide resolved
iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/EntityToolService.java
Show resolved
Hide resolved
iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/EntityToolService.java
Outdated
Show resolved
Hide resolved
iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/EntityToolService.java
Outdated
Show resolved
Hide resolved
...a/org/iplass/adminconsole/client/tools/ui/entityexplorer/datalist/EntityUpdateAllDialog.java
Outdated
Show resolved
Hide resolved
iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/EntityToolService.java
Show resolved
Hide resolved
iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/EntityToolService.java
Show resolved
Hide resolved
iplass-tools/src/main/java/org/iplass/mtp/impl/tools/entity/EntityToolService.java
Show resolved
Hide resolved
...a/org/iplass/adminconsole/client/tools/ui/entityexplorer/datalist/EntityUpdateAllDialog.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応内容
closes #1582
EntityExplorerのupdateAll機能にて以下の更新を可能にする。
動作確認・スクリーンショット
多重度複数の場合、値の指定形式として、

ARRAYとARRAY_INDEXを追加。ARRAYの場合、多重度項目に配列で値を指定して更新が可能。ARRAY_INDEXの場合、更新したい個別のインデックスを指定可能。