Skip to content

フォーマット: spotlessを導入(実行はしない)#2000

Merged
xtakahashi-hiroyuki merged 3 commits intomasterfrom
feature/1753-spotless-impl
Mar 27, 2026
Merged

フォーマット: spotlessを導入(実行はしない)#2000
xtakahashi-hiroyuki merged 3 commits intomasterfrom
feature/1753-spotless-impl

Conversation

@xtakahashi-hiroyuki
Copy link
Copy Markdown
Contributor

@xtakahashi-hiroyuki xtakahashi-hiroyuki commented Mar 26, 2026

対応内容

#1753

  1. Spotless を組み込む。
    • import最適化は組み込まない。

補足

eclipse-java-formatter.xml

EEからコピペした

動作確認・スクリーンショット(任意)

レビュー観点・補足情報(任意)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Issue #1753 の手順「2. Spotless を組み込む(import最適化は組み込まない)」に対応し、リポジトリのJavaコード整形を行うための Spotless をビルドに組み込むPRです(このPR自体では整形の実行は行わない前提)。

Changes:

  • Eclipse Java Formatterの設定XML(iPLAssコードスタイル)を追加
  • GradleにSpotlessプラグインを追加し、全プロジェクトで Eclipse formatter 設定ファイルを参照するよう設定

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
editor-settings/iplass-codestyle-eclipse/eclipse-java-formatter.xml Eclipse JDT formatterのプロファイル(iplass)を追加
build.gradle Spotlessプラグインの導入と、Eclipse formatter設定ファイルの適用設定を追加

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

@xtakahashi-hiroyuki xtakahashi-hiroyuki merged commit b523775 into master Mar 27, 2026
7 checks passed
@xtakahashi-hiroyuki xtakahashi-hiroyuki deleted the feature/1753-spotless-impl branch March 27, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants