fix: publish-suppressions action trigger

[jeremylong]

resolves #8512

[chadlwilson]

I think this will double-trigger/double-publish since the approvals workflow pushes to the branch and then triggers publish directly?

I was part way through unpicking that, but was a bit confused about the logic 😅

[chadlwilson]

Hmm, it didn't seem to double-trigger after an FP approval just now, so perhaps GH have some protection in place for internal actions pushes. Maybe my fears were misplaced 👍🏻

[chadlwilson]

Unfortunately this doesn’t seem to be working - merge of #8522 didn’t trigger anything. That’s probably also why it didn’t double trigger.

https://github.com/dependency-check/DependencyCheck/actions?query=workflow%3A%22Publish%20Suppressions%22

I suspect this is because push events run within, and use workflow definition of, the relevant branch’s context, yet the generatedSuppressions branch is not a proper branch, and has no workflows. Workflow dispatch makes you select the context, which is why it works there.

I don’t think it’s a good idea to merge the workflows over to that branch as they will potentially become out of date, or hard to maintain. I’ll have a think about how we might be able to do this maintainable with minimal changes?