fix(fp): correct hosted suppression CPE matching for regexes which previously had trailing colons#8542
Open
chadlwilson wants to merge 1 commit into
Conversation
…g colons Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
marcelstoer
approved these changes
May 22, 2026
Collaborator
Author
|
I don't fully understand how these suppressions were working before for some of the vulns to be honest. An equivalent suppression for different libs using non-regex was failing to match for some CVEs when it had a trailing Possibly some quirk in how VulnerableSoftwareIdentifiers are matched in the code and whether they end up with the version in the CPEIdentifier when matched (or not). Perhaps it depends on whether the version in use by the user actually has a CPE entry defined for that specific version in NVD or not, or it's just matching based on a Probably need to debug or look at the raw DB data coming through for the vulns.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes yet another regression from #8522 after the regex conversion - regexes which already had a trailing
:in their rule were failing to match some CPE rules from NVD because the new optional suffix was added regardless; requiring it to end in::.*to match (two colons), which would no longer match anything.Sorry @nhumblot 😅
Related issues
Have test cases been added to cover the new functionality?
no