Update set_cache_prefix task of Magento 2 recipe to modify files directly on the server#4166
Open
flobeier wants to merge 1 commit intodeployphp:masterfrom
Open
Conversation
Update set_cache_prefix task so it modifies files directly on the server to avoid permission issues during download, e. g. in CI/CD environments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was facing permission issues during the download step of the set_cache_prefix task in a CI/CD pipeline. I updated it so it avoids the download altogether and modifies files directly on the server.
I'm no PHP dev so if you see something that can be improved please let me know.
Bug fix #…?
New feature?
BC breaks?
Tests added?
Docs added?