Remove Constants pickle migration shim (1.2.1 bridge no longer needed)#178
Merged
Conversation
1.2.1 shipped with a compatibility shim that let pickles written by the old dir()-sweep __getstate__ (which included the read-only suffixes_prefixes_titles property) load without raising AttributeError. That was a one-version bridge; users who persisted pre-1.2.1 blobs can load and re-pickle under 1.2.1 before upgrading to 1.3.0. Remove the shim and its regression test, and add an upgrade note to the release log explaining the migration path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.2.1 shipped with a compatibility shim in
Constants.__setstate__that allowed pickles written by the olddir()-sweep__getstate__(which always included the read-onlysuffixes_prefixes_titlesproperty in the state dict) to load without raisingAttributeError. That was explicitly a one-version bridge.Users who have persisted pre-1.2.1 blobs can load and re-pickle under 1.2.1 before upgrading to 1.3.0. Adds an upgrade note to the release log explaining this migration path.
Changes
Constants.__setstate__test_unpickle_legacy_state_with_property_key(covered the shim)docs/release_log.rstfor the 1.3.0 entry🤖 Generated with Claude Code