Don't setLevel on the library logger#230
Merged
Merged
Conversation
Fixes #228. Libraries should attach a NullHandler and leave the level at NOTSET so applications control verbosity; setLevel(ERROR) here silently discarded log records regardless of the app's root logger configuration. __main__.py already configures its own logger for CLI use and is unaffected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 97.30% 97.29% -0.01%
==========================================
Files 13 13
Lines 815 814 -1
==========================================
- Hits 793 792 -1
Misses 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nameparser/util.pycalledlog.setLevel(logging.ERROR)on theHumanNamelogger at import time, which silently discards log records regardless of how the application configures its root/child logger levels.NullHandler) but leave the level atNOTSETso applications control verbosity.__main__.pykeeps its own explicitsetLevel(logging.ERROR)for CLI use, which is unaffected.Fixes #228
Test plan
python -m pytest -q— 1340 passed, 4 skipped, 22 xfailed🤖 Generated with Claude Code