Add bound_first_names to the config defaults automodule list#234
Merged
Conversation
docs/modules.rst documents every config module except bound_first_names (added in v1.3.0), so Sphinx references to ~bound_first_names.BOUND_FIRST_NAMES -- e.g. in the Constants class docstring -- had no target and failed to resolve in nitpicky (-n) builds. With the entry added, the two unresolved BOUND_FIRST_NAMES references drop to zero and the default build stays warning-free. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 13 13
Lines 813 813
=======================================
Hits 791 791
Misses 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/modules.rsthasautomoduleentries for six of the seven config modules;nameparser.config.bound_first_names(added in v1.3.0) was missing, so Sphinx references like~bound_first_names.BOUND_FIRST_NAMESin theConstantsclass docstring had no target.One-line fix: add the missing entry, placed after
prefixesto match the module ordering used in AGENTS.md.Verification
uv run sphinx-build -b html docs ...: build succeeded, no warnings-n): unresolvedBOUND_FIRST_NAMESreferences go from 2 on master to 0 on this branchbound_first_names-adjacent nitpicky warning (Constants.bound_first_names) is the pre-existing annotation-only-attribute pattern shared byConstants.regexesetc., unrelated to this fix🤖 Generated with Claude Code