Skip to content

Conversation

@ckiee
Copy link
Member

@ckiee ckiee commented Dec 23, 2025

Related Issues

Part-of: https://github.com/descope/etc/issues/12606

Description

As the title says.

Must

  • Tests
  • Documentation (if applicable)

Copilot AI review requested due to automatic review settings December 23, 2025 12:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Descoper management methods to the Descope Python SDK, enabling CRUD operations for Descoper entities (users with specific roles and permissions in projects).

Key Changes:

  • Implements create, load, update, delete, and list methods for Descoper management
  • Adds new data classes for Descoper attributes, RBAC configuration, roles, and creation parameters
  • Extends HTTP client with PUT method support

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/management/test_descoper.py Comprehensive test suite covering all CRUD operations with success and failure scenarios
descope/mgmt.py Registers Descoper management interface as a property of the management client
descope/management/descoper.py Core implementation of Descoper CRUD operations with validation and HTTP calls
descope/management/common.py Defines API endpoints and data classes for Descoper entities, roles, and RBAC configuration
descope/http_client.py Adds PUT HTTP method to support Descoper creation endpoint
descope/__init__.py Exports Descoper-related classes for public API access

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dorsha
dorsha previously approved these changes Dec 23, 2025
@github-actions
Copy link

Coverage report

The coverage rate went from 98.14% to 98.05% ⬇️

95.4% of new lines are covered.

Diff Coverage details (click to unfold)

descope/management/common.py

93.47% of new lines are covered (98.71% of the complete file).
Missing lines: 522, 523, 526

descope/management/descoper.py

96.77% of new lines are covered (96.77% of the complete file).
Missing lines: 74

descope/mgmt.py

100% of new lines are covered (100% of the complete file).

descope/http_client.py

100% of new lines are covered (98.76% of the complete file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants